Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix: ConfigQemu. Node, Pool, VmID #272

Closed
wants to merge 3 commits into from

Conversation

Tinyblargon
Copy link
Collaborator

Noticed that #255 broke ConfigQemu. Node, Pool, VmID

Work Done:

  • Fixed bug a752d22
  • Added unit test 761523a
  • Changed structure of existing unit test to allow for easier extension f5eb43d. The change was nesting all existing Disk tests into an array item so each top level parameter in ConfigQemu has it's own array entry. This way the item containing the Disk tasks can be collapsed making the test more readable.

@mleone87
Copy link
Collaborator

mleone87 commented Dec 6, 2023

@Tinyblargon cant merge this PR, too much mess in the resolve for test file, can you have a look?

@mleone87 mleone87 closed this Dec 6, 2023
@mleone87 mleone87 reopened this Dec 6, 2023
@Tinyblargon
Copy link
Collaborator Author

I'll look into it. It's probably easier to redo the commit than merge master back into it.

@Tinyblargon Tinyblargon deleted the BugFix-Qemu-Pool branch August 15, 2024 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants